Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform text tokens to rem in CSS variables #1944

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

splashdust
Copy link
Contributor

Other spacing tokens are still outputted as px

@green-design-system-bot
Copy link
Contributor

🦋 Changeset status

Based on the included changeset, the following releases will be published as a result of this PR:

  • @sebgroup/green-core: 1.62.5 → 1.63.0 (minor bump)

Note: If unpublished changesets where merged to main after the first commit of this PR, this
list will include those changes in addition to the ones specific to this PR.

@green-design-system-bot
Copy link
Contributor

👋 Thanks for creating a pull request!

🚀 Checkout the storybooks we've created for it:

Copy link
Member

@astrit astrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me! Although we should definitely consider the spacing tokens to update them to rem as well.

@splashdust
Copy link
Contributor Author

Look good to me! Although we should definitely consider the spacing tokens to update them to rem as well.

In general, paddings, margins, gaps, etc, should not scale with font size, so I think we'll need a more granular solution for spacing values. Perhaps some way of specifying token unit in style expression props.

@splashdust splashdust merged commit 33788ef into main Jan 24, 2025
5 checks passed
@splashdust splashdust deleted the feat/rem-transform branch January 24, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants