refactor/update-react-segmented-control-props #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrance456
changed the title
🦋 Changeset statusBased on the included changeset, the following releases will be published as a result of this PR:
Note: If unpublished changesets where merged to |
|
👋 Thanks for creating a pull request! 🚀 Checkout the storybook we've created for it: |
splashdust
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
@terrance456 Looks good, but I added the following:
- Keep
segMinWidthbut assign it tomin-width, to avoid breaking existing API - Deprecate the manual wrappers in favor of the generated ones. No need to keep having to update this manually when the underlying component changesm since the Lit wrapper already handles it automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
segmented-controlcomponent props according to latestgreen/corecomponent