fix: wrap dialog with wrapper element #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset statusBased on the included changeset, the following releases will be published as a result of this PR:
Note: If unpublished changesets where merged to |
|
👋 Thanks for creating a pull request! 🚀 Checkout the storybooks we've created for it: |
vsjolander
added a commit
that referenced
this pull request
Feb 2, 2025
* fix: input enhancment * feat: update v-angular (#1817) * feat: ng-3755 update base-control-value-accessor component * feat: ng-3755 allow thook inputs to be null or undefined * feat: ng-3755 remove whitespace * feat: ng-3628 allow thook inputs to be null or undefined * feat: pgp-29544 make tooltip accessible * feat: ng-3628 allow thook inputs to be null or undefined * feat: error list and error icon * feat: ng-3755 partial changes * feat: ng-3755 use green icon * feat: ng-3755 remove exclamation mark reference to font awesome * feat: ng-3755 error list and error icon * feat: remove fontawesome * feat: verify commit info --------- Co-authored-by: s3072g <[email protected]> Co-authored-by: Vilhelm Sjölander <[email protected]> * Radio/Checkbox: Close the gap (#1884) * close gap on checkbox and radio button * updated storybooks * fix: error alignment and added icon (#1888) Co-authored-by: s1604b <[email protected]> --------- Co-authored-by: Martina Öqvist <[email protected]> Co-authored-by: s1604b <[email protected]> * Dropdown: Close the gap (#1878) * fix: gap dropdown * fix: error in dropdown story * fix: disabling radio stories * fix: disable input story * fix using hex color code instead of variable * fix: added error message alignment fix style: html formatting * fix: re-enable radio story --------- Co-authored-by: s1604b <[email protected]> * Tooltip: Fix background color (#1882) * fix: tooltip background color * fix: arrow styling * fix: disable radio + input stories * revert: re-enable stories --------- Co-authored-by: s1604b <[email protected]> Co-authored-by: Vilhelm Sjölander <[email protected]> * Fix: v-angular alignment (#1883) * style: file formatting * fix: change back to using component decorator --------- Co-authored-by: s1604b <[email protected]> Co-authored-by: Vilhelm Sjölander <[email protected]> * Input/Textarea: Error message alignment (#1887) * fix: deprecated errorIcon and errorList inputs * fix: added styling to align icon with error text and character count-down fix: removed long deprecated input fix: removed use of withErrorIcon input --------- Co-authored-by: s1604b <[email protected]> * V-Angular - Remaining components (#1885) * Alert added * Alert additions * Datepicker first * Adding drag drop component with new styling * Adding pagination with new styling * Adding tabs with new styling * Adding Toast with styling * fix remove unused selector * WIP * Update date-input.component.html * Adding css vars for mixins - Addings css vars so chlorophyll mixings works in standalone components. - Also adding some additional styling for components to work properly. This is due to Chlorophyll styling relies on resets and global styles. * Renaming from ngv to nggv * Update pagination.component.spec.ts * Fixing tests * Fixing build * Update card.component.scss * fix: lint and test errors (#1902) * fix: unexpected lexical declaration in case block * fix: prefer-const * fix: redundant double negation - no-extra-boolean-cast * fix: typings * fix: removed empty constructors * fix: always false error * fix: disabled eq linting for line * fix: no-useless-escape error * fix: disabled @typescript-eslint/no-empty-function for two lines * fix: @typescript-eslint/no-inferrable-types * fix: disabled angular-eslint/template/eqeqeq for part of template * fix: tests throwing console errors fix: removed redundant tests --------- Co-authored-by: Martina Öqvist <[email protected]> * Dialog/fold-out/slide-out: Close the gap (#1894) * close the gap on modal components * Changing classname and fixing font size on buttons --------- Co-authored-by: Vilhelm Sjölander <[email protected]> * Input/Textarea: Close the gap (#1879) * close gap on input and teaxtarea components * fix merge conflicts * reenable radio stories * Formating v-angular (#1903) - Formating v-angular * Renaming Ngv to Nggv (#1906) * Renaming Ngv to Nggv * nx format:write * Fix/component exports (#1905) * fix: module exports * fix: date-input and input mask fixes * fix: remove browser module * fix: call with no args * Update libs/angular/src/v-angular/v-angular.module.ts Co-authored-by: pontus-github <[email protected]> * Renaming Ngg to Nggv --------- Co-authored-by: Martina Öqvist <[email protected]> Co-authored-by: Vilhelm Sjölander <[email protected]> Co-authored-by: pontus-github <[email protected]> * Adding button font-size and font-family (#1907) * Renaming sdv to gds (#1908) * Fix text area variables and datepicker input label (#1909) * Adding account number component (#1910) * fix: wrap dialog with wrapper element (#1913) Co-authored-by: Martina Öqvist <[email protected]> * Create README.md (#1912) * fixed thook input type for dropdown and dropdown-list (#1915) * fix: date-input, dropdown, input, textarea (#1930) * fix: 100% width table and button for sort (#1929) * Typeahead: Added emptyOptionLabel Typeahead input (#1928) * fix: added emptyOptionLabel typeahead input * fix: move typeahead input once the dropdown has been opened * fix: cannot convert undefined or null to object error * style: formatting * fix: prevent space when dropdown expanded * fix: active styling (removed blue background and border) --------- Co-authored-by: Martina Öqvist <[email protected]> Co-authored-by: Vilhelm Sjölander <[email protected]> * styling fixes * Create tough-bulldogs-love.md * Typeahead: Prevent default only within component scope (#1932) * fix: check event target in typeahead * fix: remove scope document --------- Co-authored-by: Martina Öqvist <[email protected]> * Input: added styling for prefix and suffix (#1924) * added styling for prefix and suffix * cleanup --------- Co-authored-by: Martina Öqvist <[email protected]> * Linting * Adding eslint-disable no-console * Update calendar.component.spec.ts --------- Co-authored-by: HappyCtrl <[email protected]> Co-authored-by: dev3072 <[email protected]> Co-authored-by: s3072g <[email protected]> Co-authored-by: pontus-github <[email protected]> Co-authored-by: Martina Öqvist <[email protected]> Co-authored-by: s1604b <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added wrapping element with class
.modal-dialog__wrapper, in which we include the wrapper mixin.