Dynamic rules #177
Merged
Dynamic rules #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've done these changes in order to dynamically generate rules and items. |
|
It looks good, but in addition to the method of adding dynamic rules, you need a method for removing these rules. |
querdenker2k
reviewed
Oct 9, 2023
| optionList.add(cp); | ||
| logDebug("Compiling classes using classpath: {}", cp); | ||
| logDebug("1337Compiling classes using classpath: {}", cp); |
There was a problem hiding this comment.
What a magic number is this?
When would you like to do this? I mean if you have a use-case? |
|
now doing it in #178 |
|
Something like this fb997f6 |
|
@querdenker2k Would be good to get a review on this, so we can merge and then continue building on the dynamic rules. |
|
I'm merging this due to now review other than querdenker2k comment above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated pull request. For dynamic rules