Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix append_text_comment rule to not add an extra space #231

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Fix append_text_comment rule to not add an extra space #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01074e7
Fix append_text_comment rule to not add an extra space
jeparlefrancais Nov 22, 2024
cb60e46
add entry to changelog
jeparlefrancais Nov 22, 2024
8b73233
Add test case
jeparlefrancais Nov 22, 2024
35fbc61
update javascript tests dependencies
jeparlefrancais Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased

* fix `append_text_comment` to not add an extra space to comments ([#231](https://github.com/seaofvoices/darklua/pull/231))
* add rule to remove floor divisions (`remove_floor_division`) ([#230](https://github.com/seaofvoices/darklua/pull/230))
* fix `remove_assertions` rule to make the `assert` calls return their arguments ([#229](https://github.com/seaofvoices/darklua/pull/229))
* add rule to remove continue statements (`remove_continue`) ([#227](https://github.com/seaofvoices/darklua/pull/227))
Expand Down
2 changes: 1 addition & 1 deletion site/content/rules/append_text_comment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ parameters:
type: '"start" or "end"'
description: The location where to add the comment
examples:
- rules: "[{ rule: 'append_text_comment', text: 'hello!' }]"
- rules: "[{ rule: 'append_text_comment', text: '!native' }]"
content: print('Print from module')
- rules: "[{ rule: 'append_text_comment', text: 'hello!', location: 'end' }]"
content: print('Print from module')
Expand Down
Loading
Loading