Fix empty dataframe handling in conditional sampling #2335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2334
Error 1:
_filter_conditions
will throw an unhandled error when trying to access any of dataframe columns, because it is empty, and sampling will be stopped:From
sdv/single_table/base.py/_sample_rows
Line causing an error from
sdv/single_table/base.py/_filter_conditions
Error 2:
filter_valid
will throw an unhandled error when trying to access any of sample dataframe columns, because it is empty, and sampling will be stopped:From
sdv/data_processing/data_processor.py/filter_valid