Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide user-friendly error messages when there are missing values in conditional sampling #1791

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

fealho
Copy link
Member

@fealho fealho commented Feb 14, 2024

CU-86az5d52d, Resolve #1758.

@fealho fealho changed the title Validate condition and provide user-friendly messages for NaN/missing values (currently unsupported) #1758 Provide user-friendly messages for errors due to missing values in conditional sampling Feb 14, 2024
@fealho fealho changed the title Provide user-friendly messages for errors due to missing values in conditional sampling Provide user-friendly error messages when there are missing values in conditional sampling Feb 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (946d2c5) 97.25% compared to head (5375d51) 97.26%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1791   +/-   ##
=======================================
  Coverage   97.25%   97.26%           
=======================================
  Files          49       49           
  Lines        4666     4679   +13     
=======================================
+ Hits         4538     4551   +13     
  Misses        128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho marked this pull request as ready for review February 14, 2024 02:41
@fealho fealho requested a review from a team as a code owner February 14, 2024 02:41
@fealho fealho requested review from pvk-developer and rwedge and removed request for a team February 14, 2024 02:41
Please enter the commit message for your changes. Lines starting
sdv/single_table/base.py Outdated Show resolved Hide resolved
@fealho fealho requested a review from rwedge February 14, 2024 16:51
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fealho fealho merged commit 7a52ed2 into main Feb 16, 2024
37 checks passed
@fealho fealho deleted the issue-1758-warning-nan branch February 16, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate condition and provide user-friendly messages for NaN/missing values (currently unsupported)
5 participants