Set credentials key as variables #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1682 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 47 47
Lines 4395 4402 +7
=======================================
+ Hits 4268 4275 +7
Misses 127 127 ☔ View full report in Codecov by Sentry. |
rwedge
reviewed
Nov 21, 2023
sdv/datasets/demo.py
Outdated
| response = urllib.request.urlopen(dataset_url) | ||
| except urllib.error.HTTPError: | ||
| file_content = _get_data_from_bucket(object_key) | ||
| except Exception: |
There was a problem hiding this comment.
is there a more specific exception type we could use here?
tests/unit/datasets/test_demo.py
Outdated
Comment on lines
69
to
73
| @patch.dict(os.environ, { | ||
| 'AWS_ACCESS_KEY_ID': 'access_key', | ||
| 'AWS_SECRET_ACCESS_KEY': 'secret_access_key', | ||
| 'AWS_DEFAULT_REGION': 'region_name', | ||
| }) |
rwedge
approved these changes
Nov 27, 2023
amontanez24
approved these changes
Nov 27, 2023
R-Palazzo
force-pushed
the
issue-1680-aws-key
branch
from
50b16e0 to
53a441e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
86ayqtfhr
Resolve #1680