-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ToggleAuditNemesisSyslog): Remove enterprise-only restriction for audit feature #9996
base: branch-2025.1
Are you sure you want to change the base?
fix(ToggleAuditNemesisSyslog): Remove enterprise-only restriction for audit feature #9996
Conversation
Interesting that the 2025.1 is not registered as enterprise, it should be (and according to other problems we have with it, it is) |
@@ -5166,8 +5166,6 @@ def _disrupt_toggle_audit(self, store: AuditStore): | |||
reduce categories by excluding DML and QUERY, | |||
verify DDL are logged in audit log correctly. Leaves audit log enabled this way. | |||
""" | |||
if not self.target_node.is_enterprise: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would replace this with version check, if the major version is lower than 6 this is unsupported nemesis
feebf60
to
d1e7a89
Compare
… audit feature This patch allows audit feature tested across all Scylla versions. Signed-off-by: Lakshmipathi.Ganapathi <[email protected]>
d1e7a89
to
30f3473
Compare
Exactly, @Lakshmipathi can you point place where audit nemesis were skipped but should not? |
@soyacz https://github.com/scylladb/scylla-cluster-tests/blob/branch-2025.1/sdcm/nemesis.py#L5169 caused this jenkins job https://argus.scylladb.com/tests/scylla-cluster-tests/781c9243-92c0-4fe1-ac8a-291b86b04373 to skip audit nemesis |
Ok, now I see. The problem is more generic than just Audit Nemesis. |
This patch allows audit feature tested across all Scylla versions.
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)