Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ToggleAuditNemesisSyslog): Remove enterprise-only restriction for audit feature #9996

Open
wants to merge 1 commit into
base: branch-2025.1
Choose a base branch
from

Conversation

Lakshmipathi
Copy link

This patch allows audit feature tested across all Scylla versions.

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@Lakshmipathi Lakshmipathi self-assigned this Feb 5, 2025
@Lakshmipathi Lakshmipathi requested review from fruch and pehala February 5, 2025 09:11
@pehala
Copy link
Contributor

pehala commented Feb 5, 2025

Interesting that the 2025.1 is not registered as enterprise, it should be (and according to other problems we have with it, it is)

@@ -5166,8 +5166,6 @@ def _disrupt_toggle_audit(self, store: AuditStore):
reduce categories by excluding DML and QUERY,
verify DDL are logged in audit log correctly. Leaves audit log enabled this way.
"""
if not self.target_node.is_enterprise:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace this with version check, if the major version is lower than 6 this is unsupported nemesis

… audit feature

This patch allows audit feature tested across all Scylla versions.

Signed-off-by: Lakshmipathi.Ganapathi <[email protected]>
@soyacz
Copy link
Contributor

soyacz commented Feb 6, 2025

Interesting that the 2025.1 is not registered as enterprise, it should be (and according to other problems we have with it, it is)

Exactly, @Lakshmipathi can you point place where audit nemesis were skipped but should not?

@Lakshmipathi
Copy link
Author

Interesting that the 2025.1 is not registered as enterprise, it should be (and according to other problems we have with it, it is)

Exactly, @Lakshmipathi can you point place where audit nemesis were skipped but should not?

@soyacz https://github.com/scylladb/scylla-cluster-tests/blob/branch-2025.1/sdcm/nemesis.py#L5169 caused this jenkins job https://argus.scylladb.com/tests/scylla-cluster-tests/781c9243-92c0-4fe1-ac8a-291b86b04373 to skip audit nemesis

@soyacz
Copy link
Contributor

soyacz commented Feb 6, 2025

Interesting that the 2025.1 is not registered as enterprise, it should be (and according to other problems we have with it, it is)

Exactly, @Lakshmipathi can you point place where audit nemesis were skipped but should not?

@soyacz https://github.com/scylladb/scylla-cluster-tests/blob/branch-2025.1/sdcm/nemesis.py#L5169 caused this jenkins job https://argus.scylladb.com/tests/scylla-cluster-tests/781c9243-92c0-4fe1-ac8a-291b86b04373 to skip audit nemesis

Ok, now I see. The problem is more generic than just Audit Nemesis.
I prepared generic fix for it: #10008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants