Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement(upgrade_test): Improve clarity for assert messages #9990

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improvement(upgrade_test): Improve clarity for assert messages #9990

wants to merge 2 commits into from

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Feb 4, 2025 •
edited
Loading

  • Improve clarify for asserts checking version changes
    • It was not obvious where the failure happened

FYI: @yaronkaikov

Testing

  • Not needed, not functional change

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Backporting, because it could help investigating upgrades in current release cycle

@pehala pehala requested a review from fruch February 4, 2025 12:48
pehala added 2 commits February 4, 2025 13:56
@pehala
improvement(upgrade_test): Improve clarity for _rollback_node assert …
6a399dd 
…message

It was not obvious, error happened during rollback
@pehala
improvement(upgrade_test): Improve clarity for _upgrade_node assert m…
f178a0f 
…essage

It could be easily confused with error during rollback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruch fruch Awaiting requested review from fruch

At least 2 approving reviews are required to merge this pull request.

Assignees

@pehala pehala

Labels
backport/2025.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pehala