fix(gemini-cmd): broken gemini commands on upgrades #9959
Merged
+118
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeLieutenant
added
test-integration
CodeLieutenant
force-pushed
the
fix--broken-gemini-commands
branch
3 times, most recently
from
f864134 to
c105b3a
Compare
When gemini_thread.py was refactored, every command in test-cases/gemini was refactored to use the new model of declaring the flags. But it was not anticipated that there were more places where gemini was used e.g. test-cases/cdc and test-cases/upgrades Signed-off-by: Dusan Malusev <[email protected]>
CodeLieutenant
force-pushed
the
fix--broken-gemini-commands
branch
from
c105b3a to
2f2fcfd
Compare
CodeLieutenant
added
test-integration
This was referenced Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When gemini_thread.py was refactored, every command in test-cases/gemini was refactored to use the new model of declaring the flags. But it was not anticipated that there were more places where gemini was used e.g. test-cases/cdc and test-cases/upgrades.
Testing
PR pre-checks (self review)
backportlabelsFixes #9850
Reminders
sdcm/sct_config.py)unit-test/folder)