feature(aws-unittests): new unit test module for test aws services #9910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need this package for better unittesting our aws integration code
the aws pricing model is suffering from cyclic depedecies this change is a workaround avoid it, if we aren't really gonna use the pricing code
with newer version of boto3 (or under moto), this call would be failing if region is not defined
fruch
added
backport/none
fruch
force-pushed
the
replace_aws_mock_tests
branch
from
8ba4635 to
5c92a70
Compare
in this modulde we would be using moto in a server mode, running inside a thread in this way we don't have external services depedecies or need to spin up docker instance with a mock implemention. for now it's just demonstrate what we can achive with it * cover Keystore implmention * cover AWS Provisioning (on case) * cover listing of AMIs
since we have replacement for the tests using this mock, we remove all the code related to it
fruch
force-pushed
the
replace_aws_mock_tests
branch
from
5c92a70 to
e2e3429
Compare
|
@fruch new branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this commit we would be using moot in a server mode, running
inside a thread
in this way we don't have external services dependencies or
need to spin up docker instance with a mock implementation.
for now it's just demonstrate what we can achieve with it
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)