scylla-node/Debian_install.yml: Don't check if the installed scylla v… #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebenzecri
approved these changes
May 10, 2024
igorribeiroduarte
requested changes
May 10, 2024
vladzcloudius
force-pushed
the
allow_scylla_version_with_custom_build
branch
from
7571f4b to
287bf80
Compare
…ersion appears in the repo exactly once unless we are upgrading We have a check that validates that a value in `scylla_version` matches exactly one (full) scylla verison from the repository so that the Role can install it. However this check is only relevant when we are going to install anything, and when scylla is already installed and we are not upgrading - we are not going to. Hence, this check is only making noise in such a case. One common example of such a situation is when a custom build is installed. Signed-off-by: Vlad Zolotarov <[email protected]>
vladzcloudius
force-pushed
the
allow_scylla_version_with_custom_build
branch
from
287bf80 to
011fb2c
Compare
igorribeiroduarte
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ersion appears in the repo exactly once
We have a check that validates that a value in
scylla_versionmatches exactly one (full) scylla verison from the repository so that the Role can install it.However this check is only relevant when we are going to install anything, and when scylla is already installed - we are not going to. Hence, this check is only making noise in such a case.
One common example of such a situation is when a custom build is installed.