scylla-node: fix scylla_setup call #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladzcloudius
force-pushed
the
node-always-run-scylla-setup
branch
3 times, most recently
from
4616f89 to
e81b67f
Compare
Add missing --no-cpuscaling-setup and --no-fstrim-setup (we explicitly setup these later in the play)
and make sure to always call `scylla_setup` - with the parameters we call it
it should be safe to call it even when scylla server is already running.
We also don't need to give '--nic {{ scylla_nic }} --setup-nic-and-disks' parameters
because they are canceled by --no-sysconfig-setup at the end of the command line
and because we are going to call scylla_sysconfig_setup later in the play explicitly.
We also needed to parametrize the memory locking setup to allow molecule run in containers
on the same VM.
Fixes scylladb#98
Fixes scylladb#339
Signed-off-by: Vlad Zolotarov <[email protected]>
Scylla ships an up to date peftune.py for quite some time. Let's remove the bits that were working around a very old breakage in it. With this patch a Role will rely on an auto-selection logic by default. And one can enforce a specific CPU set using `cpuset_command` parameter. For example: scylla_cpuset_setup --cpuset 1-7,9-15 In addition to that we need to setup cpuset.conf BEFORE we run iotune because scylla_io_setup is going to use the CPUSET value from it. Signed-off-by: Vlad Zolotarov <[email protected]>
Signed-off-by: Vlad Zolotarov <[email protected]>
vladzcloudius
force-pushed
the
node-always-run-scylla-setup
branch
from
e81b67f to
9d0b87c
Compare
We want all relevant services to be enabled. Signed-off-by: Vlad Zolotarov <[email protected]>
igorribeiroduarte
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing --no-cpuscaling-setup and --no-fstrim-setup (we explicitly setup these later in the play) and make sure to always call
scylla_setup- with the parameters we call it it should be safe to call it even when scylla server is already running.We also don't need to give '--nic {{ scylla_nic }} --setup-nic-and-disks' parameters because they are canceled by --no-sysconfig-setup at the end of the command line and because we are going to call scylla_sysconfig_setup later in the play explicitly.
Fixes #339