Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rechunk bug after spatial query #861

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

LucaMarconato
Copy link
Member

@LucaMarconato LucaMarconato commented Feb 4, 2025

Closes #821 until the root of the problem (dask/dask#11713) is addressed, and until we can update to the latest dask (dask/dask#11146).

@LucaMarconato
Copy link
Member Author

This PR also checks for the regularity of the chunks after the query, so a potential bug is found before writing to disk. We could consider adding this check into the validation functions. This last idea is tracked here: #862.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.95%. Comparing base (cab8353) to head (3adacc0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata/_core/query/_utils.py 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #861      +/-   ##
==========================================
- Coverage   92.00%   91.95%   -0.06%     
==========================================
  Files          47       47              
  Lines        7331     7345      +14     
==========================================
+ Hits         6745     6754       +9     
- Misses        586      591       +5     
Files with missing lines Coverage Δ
src/spatialdata/_core/query/_utils.py 81.65% <66.66%> (-2.56%) ⬇️

@LucaMarconato LucaMarconato merged commit 0e20de6 into main Feb 4, 2025
7 checks passed
@LucaMarconato LucaMarconato deleted the fix/rechunk-after-query branch February 4, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to save subsetted Xenium sdata to .zarr
1 participant