update harmony to new implementation #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ll check this out tomorrow, it’s too big to start now! |
flying-sheep
requested changes
Dec 17, 2024
There was a problem hiding this comment.
The harmonize function has a really nice layout. it’s easy to follow what it does, nice!
However it seems like you’re establishing a bunch of parameters that get reused and never changed after the initialization. You could e.g.
- create it a frozen dataclass with methods so you can use the parameters using
self.<name>, or - create a
NamedTuplethat you can pass around containing the parameters
There was a problem hiding this comment.
- don’t name variables LIKE_CONSTANTS
- don’t name variables with single letter names (except for
a, bfor binary operators,iforenumerateand similar conventions)
There was a problem hiding this comment.
the variables still have weird names with capital letters in them
Co-authored-by: Philipp A. <[email protected]>
Co-authored-by: Philipp A. <[email protected]>
|
removed all prints and added a warning if harmony didnt converge |
flying-sheep
requested changes
Dec 19, 2024
There was a problem hiding this comment.
the variables still have weird names with capital letters in them
|
Most of the names are just taken from the reference implementation |
flying-sheep
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #299