Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added yaml for gpu_ci #1359

Merged
merged 6 commits into from
Feb 7, 2024
Merged

added yaml for gpu_ci #1359

merged 6 commits into from
Feb 7, 2024

Conversation

Intron7
Copy link
Member

@Intron7 Intron7 commented Feb 7, 2024

Adds Yaml file for the GPU test environment. This might help with #1357

@Intron7 Intron7 added this to the 0.10.6 milestone Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (532ba3b) 83.71% compared to head (1b3d712) 85.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
+ Coverage   83.71%   85.83%   +2.12%     
==========================================
  Files          35       35              
  Lines        5564     5564              
==========================================
+ Hits         4658     4776     +118     
+ Misses        906      788     -118     
Flag Coverage Δ
gpu-tests 52.24% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@Intron7 Intron7 requested a review from ivirshup February 7, 2024 13:12
@ivirshup
Copy link
Member

ivirshup commented Feb 7, 2024

Seeing a different error (but still failures) if I bump the cuda version to 12.3 https://github.com/scverse/anndata/actions/runs/7815601152/job/21319267093?pr=1360

@ivirshup
Copy link
Member

ivirshup commented Feb 7, 2024

I'm going to merge this as a temporary fix, but I think its bad that we are now only testing with a version of CUDA from 2022, so will keep tracking this for the next release.

@ivirshup ivirshup merged commit 4b4c92f into main Feb 7, 2024
14 checks passed
@ivirshup ivirshup deleted the gpu_ci_with_conda branch February 7, 2024 14:07
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Feb 7, 2024
ivirshup pushed a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants