Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configurable disableTimeOut #717

Merged
merged 6 commits into from
Oct 2, 2019

Conversation

exequiel09
Copy link
Contributor

Fixes: #578

With this change, users can now specify boolean or any of the two timeouts in the library (timeOut and extendedTimeOut) in the disableTimeOut option to disable both, disable any of them, or no disable at all.

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #717 into master will increase coverage by 0.19%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
+ Coverage   54.76%   54.96%   +0.19%     
==========================================
  Files          19       19              
  Lines         504      504              
  Branches       92       92              
==========================================
+ Hits          276      277       +1     
  Misses        192      192              
+ Partials       36       35       -1
Impacted Files Coverage Δ
src/lib/toastr/toastr-config.ts 89.47% <ø> (ø) ⬆️
src/lib/toastr/toast-noanimation.component.ts 8.6% <0%> (ø) ⬆️
src/lib/toastr/toast.component.ts 70.4% <50%> (-1.03%) ⬇️
src/lib/toastr/toastr.service.ts 46.8% <0%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5299daf...5bbad4d. Read the comment docs.

@scttcper
Copy link
Owner

scttcper commented Oct 1, 2019

This is okay, but I'm not sure how it's different from setting the timeout or extended timeout to 0.

@scttcper scttcper changed the title Configurable disableTimeOut feat: Configurable disableTimeOut Oct 2, 2019
@scttcper scttcper merged commit 475b15f into scttcper:master Oct 2, 2019
@scttcper
Copy link
Owner

scttcper commented Oct 2, 2019

🎉 This PR is included in version 11.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to disable only extended Timeout?
2 participants