Dcap 04 #1629
Dcap 04 #1629
Conversation
There was a problem hiding this comment.
Okay, it's quite a bit of code but I think I reviewed most of it. I focused mainly on the stuff inside the enclave since that should be most of the critical path. Either way, I think these comments are a good place to start.
For the most part it looks good - I think especially for someone that hasn't had much experience with Rust it's in a pretty good state.
Some general stuff:
I suggest splitting all the dcap and EPID stuff into different files - it's not entirely clear where one ends and where another begins, and so it's hard to see whether all the code paths that currently rely on epid have been ported to dcap.
We could also use a bit more comments on what exactly is going on here, as all the validation stuff isn't trivial.
Try to use more informative naming where possible (size_dcap_q or size_dcap_s are not great)
If you're using unsafe anywhere you should comment on why you're doing that, and why it's okay - if you're not specifically doing FFI a lot of the times you might find that you're doing something unnecessary
No description provided.