Test contract state after failing submsg #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshelB
requested review from
Cashmaney,
toml01,
assafmo and
liorbond
as code owners
…a faulty sdk msg. once when this msg is added on the reply endpoint, and once on the regular execute
…-after-failing-submsg
…tract-state-after-failing-bank-submsg Conflicts: cosmwasm/contracts/v1/compute-tests/test-compute-contract/src/contract.rs
…ing-bank-submsg added another test where the submsg issues a failing bank message
toml01
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make sure that submessages in contracts behave in the way stated by cosmwasm, in particular that the state of a contract A is saved even if it issues a submessage to contract B, which fails. only contract B's state should be reverted (edit: as long as the caller handles the reply).
There was no such test so I added one.
The flow of the test is as follows:
(contract:message)
quick_failsubmessage to Athe response should be the original counter incremented by 1, as the first increment should take effect, but not the second one.
Edit: Second case: No handling of reply
Now the final result should be that of the submessage so everything should revert. But the revert of the main call does not happen in tests, because we create our own keeper. we check for presence of error, which tells sdk to revert in reality.