-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump both tracing and tracing-effectful to 1.0.0.0 #12
Conversation
@@ -33,7 +33,7 @@ library | |||
, base <5 | |||
, effectful-core >=1.0.0.0 && <3.0.0.0 | |||
, exceptions <0.11 | |||
, tracing >=0.0.7 && <1.0.0.0 | |||
, tracing <=1.0.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: no upper bound?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean lower ? (To be honest, it's mostly to satisfy the CI, it should probably ==
here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 Yes :)
In that case it's just fine
BTW Cabal now also allows 1.0.*
I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've put ==
(and the bound checker of the CI seems ok with it 😌), as this is directly linked to the library, I think we should use an exact version for now.
@@ -1,6 +1,6 @@ | |||
cabal-version: 3.0 | |||
name: tracing-effectful | |||
version: 0.1.0.0 | |||
version: 1.0.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't need to a major-major bump here, is the idea to keep this version in sync with tracing
?
If so, we should add a comment about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In sync would be a bit much, it was more for the sake of parallelism (I find it be a bit weird to have ŧracing
be 1.0.0.0 and tracing-effectful
be 0.1.0.0);
abc4e3d
to
cdd0065
Compare
Let's use proper versioning.