Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTY Issues #77

Merged
merged 1 commit into from
Aug 16, 2021
Merged

PTY Issues #77

merged 1 commit into from
Aug 16, 2021

Conversation

carlmontanari
Copy link
Contributor

do not force pty for netconf connections; flag to control this for sytem transport

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #77 (dad399f) into develop (ac141d4) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #77      +/-   ##
===========================================
+ Coverage    78.03%   78.22%   +0.19%     
===========================================
  Files           16       16              
  Lines          915      914       -1     
===========================================
+ Hits           714      715       +1     
+ Misses         201      199       -2     
Impacted Files Coverage Δ
...li_netconf/transport/plugins/paramiko/transport.py 50.00% <ø> (+3.84%) ⬆️
...crapli_netconf/transport/plugins/ssh2/transport.py 0.00% <ø> (ø)
...apli_netconf/transport/plugins/system/transport.py 60.71% <100.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac141d4...dad399f. Read the comment docs.

@carlmontanari carlmontanari merged commit 9c4a123 into develop Aug 16, 2021
@carlmontanari carlmontanari deleted the flag_to_disable_pty branch August 16, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant