Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to newer score-go and go 1.21 #47

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

astromechza
Copy link
Member

@astromechza astromechza commented Feb 1, 2024

This PR upgrades this repo to the latest commit of score-go score-spec/score-go@562be83 which brings in the generated Go types. This ensures that the repo stays aligned with the fields supported in the official score schema file and that there is a clear source of provenance for the types (the dependency tag should be easier to match to a commit in the score-go repo).

This is functionally a no-op with no resulting changes for any of the test cases.

We also upgrade the required Go version to 1.21 (August 2023).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

Copy link

@delca85 delca85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@astromechza astromechza merged commit 2b7046e into main Feb 2, 2024
3 checks passed
@astromechza astromechza deleted the upgrade-to-generated-types branch February 2, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants