Skip to content

Commit

Permalink
fix: clarify note in readme regarding probes (#244)
Browse files Browse the repository at this point in the history
Signed-off-by: Ben Meier <[email protected]>
  • Loading branch information
astromechza authored Jan 20, 2025
1 parent 5f53293 commit cd62596
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
| Feature | Support | Impact |
|------------------------------------------------------------------------------|---------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `containers.*.resources.limits` / `containers.*.resources.requests` | none | **Limits will be validated but ignored.** While the compose specification has some support for this, it is requires particular Docker versions that cannot be relied on. *This should have no impact on Workload execution*. |
| `containers.*.livenessProbe.httpGet` / `containers.*.readinessProbe.httpGet` | none | **Probes will be validated but ignored.** The Score specification only details K8s-like HTTP probes, but the compose specification only supports direct command execution. We cannot convert between the two reliably. *This should have no impact on Workload execution*. Tracked in [#86](https://github.com/score-spec/score-compose/issues/86). |
| `containers.*.livenessProbe.httpGet` / `containers.*.readinessProbe.httpGet` | none | **Probes will be validated but ignored.** The Score specification details both command execution and HTTP probes, but the compose specification only supports direct command execution. We cannot convert between the two reliably, so the `exec` mode is ignored *This should have no impact on Workload execution*. Tracked in [#86](https://github.com/score-spec/score-compose/issues/86). |

## Resource support

Expand Down

0 comments on commit cd62596

Please sign in to comment.