Feature: Placeholder Sprites #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The headline feature here is that we now support being logged in and searching for private replays. We also have a new button to instantly find your own replays. Also here is the basics of HTML5 history support. It's the first step to having the two-column layout up and running!
Old Replays's two column support was the Panel system most notably shown off by PSDex. It was definitely very nice but a bit hard to port to Preact. This new one, written from scratch, has a few niceities: - topbar can scroll offscreen - only one scrollable area (scroll wheel works everywhere, and the PageUp/PageDown/Spacebar keys are unambiguous) - uses very little JavaScript when resizing; most of the layout work is done by CSS With the drawbacks: - no animation - only two columns supported (not relevant to Replays which has never used over two columns) - uses a lot of modern CSS (overflow: sticky, and flexbox) but should degrade gracefully
New Replays now supports adding `?p2` to the end of a replay URL, to see the replay from the opposing viewpoint. Search results will now automatically be from the viewpoint of the player you're searching for. Viewpoint is now a selector rather than a "Switch sides" button, which should hopefully be clearer about what it's doing.
New name is a lot clearer.
This also includes some refactors. Polyfills are now gone from utils.ts (I'm not sure why they were ever there; they're redundant with ps-polyfill.js) and there's a new Net.decodeQuery.
This makes the left sidebar less cramped on the biggest displays (specifically, MacBook Pro 14" and up).
I nearly missed this feature from Old Replays, but I was comparing the two side by side and noticed it.
Specifically, the bugs fixed are to searches not updating correctly.
Mostly this makes dark mode darker, but it does come with a whole suite of other design improvements.
- Updates New Replays for the design refresh - Updates STYLING.html for the design refresh Fixes #2177
Fixes #1991 (Removing a move by clicking on it in search didn't actually remove it from the set.) Fixes #2134 (Sorting and clicking on a filter would clear the currently selected pokemon/move textbox, but this was only supposed to happen when searching for a filter.)
PR #2164 added duplicate copies of these functions to battle.ts which is already quite overloaded. This temporarily relocates them to battle-dex, in preparation for a longer-term deduplication probably involving moving the storage.js implementation there. The API has been revised slightly, to match the server's sim/teams.ts.
PR #2162 removed the CSS on downloaded replays without any explanation. I think it was intended to save space and/or make things bigger? But it came with a number of bugs. - downloaded replay logs are much wider than intended - downloaded replays now have a "battle options" button that does nothing - downloaded replays have some unstyled text in e.g. popups - MOST IMPORTANTLY: downloaded replays are no longer styled when you don't have an internet connection Anyway, reverting that change fixes all these issues, and doesn't seem to cause any new ones? This is a temporary measure while waiting for Karthik to explain why the CSS removal was done in the first place. Refs #2165
- Teams in folders in the team dropdown were unstyled - `.button.disabled` wasn't taking precedence over `.button.notifying`
The idea is to eventually move all client parts to their domain name subdirectory, for clarity and better organization. New Replays is just first. Anyway, yeah, minor updates to New Replays, but otherwise it's just getting deployed as-is, straight to https://replay.pokemonshowdown.com/ The old URLs are getting taken down; they were only used for development anyway.
I was watching an old replay and noticed it no longer worked. Turn 7 of https://replay.pokemonshowdown.com/randombattle-247965078 Apparently when I did this rename, I didn't bother to make it backwards compatible with old replays? 9aba6a3
I completely missed that this was being used...
This should make Google search results and Discord link previews for replays work correctly. This actually involved a ton of work, but at least this work also makes replays load faster.
We originally let PS be embedded because I was happy to get more attention, but at this point it's no longer a good idea. (also add a logo update I missed from 9d8655c )
Files meant to be served have been moved into `play.pokemonshowdown.com/` and `pokemonshowdown.com/`. We now have three directories for the three subdomains handled by this repo: - `pokemonshowdown.com/` - `play.pokemonshowdown.com/` - `replay.pokemonshowdown.com/` Naming them after the subdomains will make it much easier to tell where the files for each go. The diff is probably useless; it'll be easier if you just look at the new tree: https://github.com/smogon/pokemon-showdown-client/tree/reorganize
It was previously throwing errors about 'no client_id provided', this fixes that by the initialization code for auth2 first (suggested by several google results and confirmed to work by me.)
I'm trying to centralize config.
(Also fixes the build error.)
(Introduced in - you guessed it - the directory reorg.)
This stuff isn't really relevant to anyone trying to develop at home, anyway.
At some point we need to update eslint but now is not that point.
Made the animations for the various types of Tera Blast various kinds of beam or blast moves (or in the case of Grass, the closest thing to that).
This reverts commit 0408736.
November 18, 2023: Merge with PS
…client into placeholder-sprites
|
wtf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in the Substitute sprite as a placeholder for empty sprite images on Fakemons.