Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for resizing image to crop box's longest side (on image load) #88

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cornellsteven
Copy link

I like that the loaded image is automatically centered when it's loaded, but I find it helpful to automatically resize the image to fit to width or height (depending on whether the crop box is portrait or landscape).

And since it's just an option, it obviously won't do it automatically.

@lucianobosco
Copy link

Great! thank you so much, it works perfect!

@cornellsteven
Copy link
Author

@luchorengo I'm glad someone else found it useful! Glad I could help.

@sconsult
Copy link
Owner

Hi @cornellsteven

I tested your code, and the initial load works perfectly. However in my testes there were issues with zooming after the load. (jumps directly to out of fitthelongest mode)

If you want to take a look at that it would be great, otherwise i can promise you we will use your code as baseline for the next update

Cheers and thank you for your contribution.

Mat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants