Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the form using css display instead of visibility #171

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Hide the form using css display instead of visibility #171

wants to merge 2 commits into from

Conversation

codaxe
Copy link

@codaxe codaxe commented Oct 6, 2015

The visibility attribute keeps the element in the DOM flow and can cause UI artifacts.

codaxe added 2 commits October 6, 2015 00:24
Previously visibility kept the element in the DOM and can cause display
artifacts.
Removed empty lines and fixed 'stlyes' typo
@jarodxxx
Copy link

jarodxxx commented Nov 3, 2015

I had the same probleme,
the solution is to add an width:0 ans height:0 in the .js file Line 142
replace:

var formHtml = '<form class="' + that.id + '_imgUploadForm" style="visibility: hidden; ">  <input type="file" name="img" id="' + that.id + '_imgUploadField">  </form>';

by

 var formHtml = '<form class="' + that.id + '_imgUploadForm" style="visibility: hidden; height:0; width:0;">  <input type="file" name="img" id="' + that.id + '_imgUploadField">  </form>';

@sconsult
Copy link
Owner

The issue with display:none vs visibility:hidden is the compatibility with IE9 and EI10. I agree with your assessment, however we have decided to not merge this request based on the know compatibility issues.

I will leave it open as a reference for others with the same issue. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants