Skip to content

Commit

Permalink
feat: use image instead of image_name
Browse files Browse the repository at this point in the history
  • Loading branch information
scmmishra committed Dec 2, 2023
1 parent c4635de commit 713675a
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ Slick Deploy is a command-line tool designed to facilitate zero-downtime deploym
> [!WARNING]
> Slick is not ready for production, but you can give it a shot if you're feeling adventurous

## Features

- Zero-downtime deployment: Update your running application without interrupting service.
Expand Down Expand Up @@ -71,7 +70,7 @@ Create a config.yaml file with your deployment settings. Here's an example confi
```yaml
app:
name: "memos"
image_name: "ghcr.io/usememos/memos"
image: "ghcr.io/usememos/memos"
container_port: 5230
registry:
username: "<username>"
Expand Down
2 changes: 1 addition & 1 deletion internal/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type RegistryConfig struct {

type App struct {
Name string `yaml:"name"`
ImageName string `yaml:"image_name"`
ImageName string `yaml:"image"`
Registry RegistryConfig `yaml:"registry"`
ContainerPort int `yaml:"container_port"`
ENV []string `yaml:"env"`
Expand Down
4 changes: 2 additions & 2 deletions internal/config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestLoadConfigSuccess(t *testing.T) {
_, err = tempFile.WriteString(`
app:
name: "Test App"
image_name: "testapp/image"
image: "testapp/image"
container_port: 8080
env: ["ENV_VAR=VALUE"]
port_range:
Expand Down Expand Up @@ -104,7 +104,7 @@ func TestLoadConfigRegistry(t *testing.T) {
_, err = tempFile.WriteString(`
app:
name: "Test App"
image_name: "testapp/image"
image: "testapp/image"
container_port: 8080
registry:
username: "testuser"
Expand Down
2 changes: 1 addition & 1 deletion sample.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
app:
name: "memos"
image_name: "ghcr.io/usememos/memos"
image: "ghcr.io/usememos/memos"
container_port: 5230
env:
- AWS_S3_ACCESS_KEY_ID
Expand Down

0 comments on commit 713675a

Please sign in to comment.