Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/v91-bugfix' into v9-minor
Browse files Browse the repository at this point in the history
  • Loading branch information
scip-ci committed Jul 19, 2024
2 parents 316d32a + 86dabc4 commit 13df56a
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ Fixed bugs
- compare coefficient scales to detect parallelism to avoid integral relaxations in detectRedundantConstraints() of cons_linear.c
- remove coefficient information from linear constraint hashes in order to compare keys with tolerances
- fixed NULL pointer dereference in SCIPtpiGetNumThreads() of TinyCThread interface if called before SCIPtpiInit(); now returns 0 in this case
- calling SCIPsolveConcurrent() when SCIP was compiled without a TPI now results in a plugin-not-found error

Performance improvements
------------------------
Expand Down Expand Up @@ -3102,7 +3103,6 @@ Interface changes

- Misc:
- changed return type of SCIPcliqueGetId() from `int` to `unsigned int`
- SCIPsolveParallel() is deprecated; use SCIPsolveConcurrent() instead
- removed SCIPvarGetCliqueComponentIdx(); the connectedness information of the clique table is now stored as a
`SCIP_DISJOINTSET` member of the clique table and cannot be publicly accessed
- added parameter `copytables` to SCIPcopyPlugins()
Expand Down
2 changes: 2 additions & 0 deletions make/make.project
Original file line number Diff line number Diff line change
Expand Up @@ -518,8 +518,10 @@ TPILDFLAGS = -openmp$(LINKLIBSUFFIX)
endif
else ifeq ($(TPI),tny)
TPICFLAGS =
ifneq ($(COMP),msvc)
TPILDFLAGS = -lpthread
endif
endif

TPILIB = $(TPILIBNAME).$(BASE)
TPILIBFILE = $(SCIPREALPATH)/lib/$(LIBTYPE)/lib$(TPILIB).$(LIBEXT)
Expand Down
2 changes: 1 addition & 1 deletion src/scip/dialog_default.c
Original file line number Diff line number Diff line change
Expand Up @@ -2147,7 +2147,7 @@ SCIP_DECL_DIALOGEXEC(SCIPdialogExecConcurrentOpt)
case SCIP_STAGE_PRESOLVING:
case SCIP_STAGE_PRESOLVED:
case SCIP_STAGE_SOLVING:
SCIP_CALL( SCIPsolveParallel(scip) );
SCIP_CALL( SCIPsolveConcurrent(scip) );
break;

case SCIP_STAGE_SOLVED:
Expand Down
4 changes: 2 additions & 2 deletions src/scip/scip_solve.c
Original file line number Diff line number Diff line change
Expand Up @@ -2862,8 +2862,8 @@ SCIP_RETCODE SCIPsolveConcurrent(
)
{
#ifdef TPI_NONE
SCIPinfoMessage(scip, NULL, "SCIP was compiled without task processing interface. Parallel solve not possible\n");
return SCIP_OKAY;
SCIPerrorMessage("SCIP was compiled without task processing interface. Concurrent solve not possible\n");
return SCIP_PLUGINNOTFOUND;
#else
SCIP_RETCODE retcode;
int i;
Expand Down
1 change: 1 addition & 0 deletions src/scip/scip_solve.h
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ SCIP_RETCODE SCIPsolve(
*
* @deprecated Please use SCIPsolveConcurrent() instead.
*/
SCIP_DEPRECATED
SCIP_EXPORT
SCIP_RETCODE SCIPsolveParallel(
SCIP* scip /**< SCIP data structure */
Expand Down

0 comments on commit 13df56a

Please sign in to comment.