Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support data= #142

Merged
merged 1 commit into from
Mar 9, 2021
Merged

feat: support data= #142

merged 1 commit into from
Mar 9, 2021

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Mar 9, 2021

See scikit-hep/boost-histogram#421. This now supports setting data= on (normal) construction (not supported in QuickConstruct mode).

@henryiii
Copy link
Member Author

henryiii commented Mar 9, 2021

Not filling out the users guide just yet because it's a pain to start up a jupyterlab instance just to edit docs. I'll probably look into converting the docs into MyST, so that I can edit them in an editor (without futzing with JSON, anyway).

@henryiii henryiii merged commit 92ef7d0 into master Mar 9, 2021
@henryiii henryiii deleted the feat/data branch March 9, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant