OH without OHMS but with PDF can embed PDF in a tab #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experiment, needs evaluation. And tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment, needs evaluation. ref #986
There are two main reasons I think this needs evaluation:
The UI is a bit weird. It's the best I could figure out, but the scrollbar-within-a-scrollbar of asking the browser to embed a PDF makes it kind of confusing in some cases.
Right now, the software architecture has no way to know which is the "transcript PDF". It only knows "here are the members whihc are PDFs". Current logic for this feature just takes the first PDF found, and assumes it's the transcript. For the actual current use cases we plan to use this template, that assupmption should be valid, there should only BE one PDF. (For OH's, we currently have two PDF's only for non-immediate-access, which... we think don't use this template).
But it's kind of fragile and easy for that assumption to become untrue in the future maybe, and then this won't do the right thing.
Should we add an architectural component to give a work member a "role"? This isn't the first time that woudl be convenient, in OH's specifically. Transcript, front matter (which could then be automatically labelled), portrait, etc.
That would potentially require staff to do more work on ingest, assigning roles to some members, so we'd need to discuss this. But it might be time to consider that architectural enhancement, even though it exceeds the boundaries of the "PCDM" model a bit.