7 feature request GitHub action to verify on push #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayPi4c
approved these changes
May 20, 2024
.github/workflows/verify.yaml
Outdated
| distribution: 'temurin' | ||
| cache: maven | ||
| - name: Verify with Maven | ||
| run: mvn --batch-mode --update-snapshots package # verify needs gpg key |
There was a problem hiding this comment.
Maybe we can use the maven wrapper for the maven tasks to be consistent about the usage of our tools and their versions.
./mvnw
In Kurtama this command is used. I don't know if there were some shenanigans in place to make it work.
There was a problem hiding this comment.
It's a problem on windows while running a bash script. There shouldn't be a problem here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (keep all applicable)
Description
GitHub action to verify changes to the project. Note, that the verify phase needs the gpg key. Therefore, I have limited it to the package phase, which includes the JUnit tests.
Related Tickets & Documents