Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#911: Check formatting in GitHub Actions #914

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

saeltz
Copy link
Collaborator

@saeltz saeltz commented Dec 30, 2024

Fixes #911.

Also formats one file to succeed the GitHub Actions.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.95%. Comparing base (fa90063) to head (de9fb72).
Report is 70 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage   88.08%   83.95%   -4.14%     
==========================================
  Files         142       21     -121     
  Lines        1578      324    -1254     
  Branches      278       31     -247     
==========================================
- Hits         1390      272    -1118     
+ Misses        188       52     -136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saeltz saeltz marked this pull request as ready for review December 30, 2024 19:23
@saeltz saeltz requested a review from mccartney December 30, 2024 19:24
@saeltz
Copy link
Collaborator Author

saeltz commented Jan 16, 2025

@mccartney, would you take a look please?

Copy link
Collaborator

@mccartney mccartney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@mccartney
Copy link
Collaborator

Feel free to tag me whenever you need. TBH I am not following the project that closely anymore, but happy to help.

@saeltz saeltz merged commit 07b9e08 into scapegoat-scala:master Jan 16, 2025
14 of 15 checks passed
@saeltz saeltz deleted the 911 branch January 16, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check formatting in GitHub Actions
2 participants