Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARTESCA-13969 // Migration to React 18 #4482

Merged
merged 7 commits into from
Jan 29, 2025
Merged

ARTESCA-13969 // Migration to React 18 #4482

merged 7 commits into from
Jan 29, 2025

Conversation

hervedombya
Copy link
Contributor

Component:

Context:

Summary:

Acceptance criteria:

Closes: #ISSUE_NUMBER

@hervedombya hervedombya requested a review from a team as a code owner November 20, 2024 17:04
@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2024

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Nov 21, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Nov 22, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Nov 25, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@hervedombya hervedombya force-pushed the feature/ARTESCA-13969 branch 2 times, most recently from ee63062 to f08ccc2 Compare November 25, 2024 15:56
@bert-e
Copy link
Contributor

bert-e commented Nov 25, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Nov 26, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@hervedombya hervedombya force-pushed the feature/ARTESCA-13969 branch from 325a2a0 to 8915ae1 Compare November 26, 2024 17:23
@bert-e
Copy link
Contributor

bert-e commented Nov 27, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@hervedombya hervedombya force-pushed the feature/ARTESCA-13969 branch from 9d91041 to 7129943 Compare November 27, 2024 14:17
@bert-e
Copy link
Contributor

bert-e commented Dec 2, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Dec 5, 2024

Conflict

There is a conflict between your branch feature/ARTESCA-13969 and the
destination branch development/129.0.

Please resolve the conflict on the feature branch (feature/ARTESCA-13969).

git fetch && \
git checkout origin/feature/ARTESCA-13969 && \
git merge origin/development/129.0

Resolve merge conflicts and commit

git push origin HEAD:feature/ARTESCA-13969

@bert-e
Copy link
Contributor

bert-e commented Dec 12, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@hervedombya hervedombya force-pushed the feature/ARTESCA-13969 branch from 3e5e92f to 2f056ee Compare December 13, 2024 13:12
@hervedombya hervedombya force-pushed the feature/ARTESCA-13969 branch 3 times, most recently from b2b937f to d0ff9f0 Compare January 25, 2025 14:24
eg-ayoub and others added 3 commits January 25, 2025 15:24
@eg-ayoub @hervedombya
fix VERSION file contents
92c1f5b
@hervedombya
Release 128.0.2
91a6ea7
@hervedombya
ARTESCA-13969 // Migration to React 18
62c890a 
ARTESCA-13969 // Migration to React 18

refactor: update NotificationCenter styles and improve test assertions

refactor: migrate to React 18's createRoot for rendering

refactor: implement external store for WebFingers context and update related hooks

refactor: remove console logs and simplify state update logic in WebFingersStore

refactor: update dependencies to React 18 and related packages

Add ShellHooksProvider and integrate shell hooks into FederableApp

Add shell hooks integration and update useAlerts function to accept optional filters

Pass shellHooks and shellAlerts as props to FederatedComponent in ProtectedFederatedRoute

Add @types/react-router-dom to package.json

Refactor to useShellHooks for improved context integration across components

Refactor context creation to eliminate reliance on window.shellContexts

Update module-federation dependency and enhance shell hooks integration in FederatedApp

Update @scality/module-federation dependency to latest version

refactor: update history management and fix type errors across components

Add routing support and refactor PrivateRoute component

Refactor history type definitions and update package versions

Add patch for react-query and refactor ShellHooksContext imports

Add TextEncoder and TextDecoder polyfills to setupTests

Refactor AlertPage and VolumePageRSP to use dynamic base paths for navigation

Update @scality/core-ui dependency to latest version and refactor tests for improved readability

Add TextEncoder and TextDecoder polyfills, refactor App component to pass location prop, and update @scality/core-ui dependency

Remove obsolete patch for react-query and update QueryClientProvider type definition

Refactor QueryClientProvider usage and remove redundant imports in tests

Update ShellHistoryProvider to use react-router's NavigateFunction and upgrade @scality/core-ui to version 0d55701c

Update Node.js version to 20-alpine3.19 in versions.py

Update navigation in DashboardInventory to use dynamic base path from state

Update Node.js version to 20.11.1 in versions.py

Update @scality/module-federation dependency to a newer commit hash

Expose useNotificiationCenter hook

Test fix cypress

Fix tabs issue

Fix routing issues

Mocked useCurrentAPp

Fix navigation issues

revert cypress conf

Fix nodelist.spec.js

Fix node tests

Fix volumes tests

bump runner memory

Add a selector to wait for nodes retrieval

Bump cyress

fix cypress

Add missing deps

delete cypress cucumber

Update Cypress integration test command and add missing querystring dependency

Enable experimental memory management and update Cypress integration test command to use Chrome browser

Refactor volume creation form commands to use role-based selectors for improved accessibility

update package-lock

Revert "update package-lock"

This reverts commit f98732d.

Update Node.js setup script to use version 20.x

Update @scality/module-federation dependency to a newer commit hash

Update Node.js setup script to use version 16.x

Update @scality/core-ui and @scality/module-federation dependencies to stable versions

Refactor imports to use @scality/module-federation instead of local ShellHooksContext

Remove unused TypeScript definitions and update JSX element return types to use the new import syntax

Refactor useConfig call in FederableApp and update mock implementation in setupTests

Rename e2e test script to integration in package.json

Update mock implementation of @scality/module-federation to use react-router's useNavigate

Update default test filter from e2e to integration in GitHub Actions

Rename cypress.config.ts to cypress.config.js and update export syntax

Update configuration for UI components and API routing

Update integration test command to use Chrome browser

Add step to install Chrome on Bastion for UI testing

Update Bastion UI tests action to install Chrome using yum

Update Bastion UI tests action to install a specific version of Chrome

Refactor Bastion UI tests action to install Chrome using a repository configuration

Update Bastion UI tests action to install glibc and Google Chrome

Add steps to update system packages and install SELinux library in Bastion UI tests action

Update Bastion UI tests action to install Chromium and adjust integration tests

Remove system package update step and upgrade Node.js setup to version 18 in Bastion UI tests action

Downgrade Node.js setup to version 17 in Cypress requirements script

Update Bastion UI tests action to install Docker and run Cypress tests in a container

Downgrade Node.js setup to version 16 in Cypress requirements script

Add user to Docker group in Bastion UI tests action

Refactor Bastion UI tests action to install Chromium and streamline test execution
@hervedombya hervedombya force-pushed the feature/ARTESCA-13969 branch from d0ff9f0 to 62c890a Compare January 25, 2025 14:24
@JBWatenbergScality
Copy link
Contributor

/bypass_author_approval

@bert-e
Copy link
Contributor

bert-e commented Jan 28, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

The following options are set: bypass_author_approval

@JBWatenbergScality
Copy link
Contributor

/create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jan 28, 2025

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/126.0
  • development/127.0
  • development/128.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: bypass_author_approval, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jan 29, 2025

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/129.0

  • ✔️ development/130.0

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/126.0
  • development/127.0
  • development/128.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: bypass_author_approval, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jan 29, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/129.0

  • ✔️ development/130.0

The following branches have NOT changed:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/126.0
  • development/127.0
  • development/128.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue ARTESCA-13969.

Goodbye hervedombya.

@bert-e bert-e merged commit bbd5d37 into development/129.0 Jan 29, 2025
27 checks passed
@bert-e bert-e deleted the feature/ARTESCA-13969 branch January 29, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBWatenbergScality JBWatenbergScality JBWatenbergScality approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hervedombya @bert-e @JBWatenbergScality @eg-ayoub