Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [ISSUE-708] Extract interface from Microservices #710

Closed

Conversation

eutkin
Copy link

@eutkin eutkin commented Feb 18, 2020

Modification sketches for DI extraction to a separate module.

Sample plan:

  1. Create new interface for Microservices.
  2. Create new interface for ServiceProvider ([Microservices, Mono<Collection<ServiceInfo>>]) for lazy services initialization. For example, Spring:
    microservices -> {
      var appContext = new GenericApplicationContext();
      // setup beans
      return Mono.defer(() -> 
    			appContext.getBeansByAnnotation(Service.class));
    }
  3. Replace service instance to service instance supplier (for lazy) and service interface with @Service (as Class<?>) in ServiceInfo.
  4. Change method register, method invoker (linked change set of ServiceInfo)
  5. ???
  6. Profit

@eutkin eutkin self-assigned this Feb 18, 2020
@eutkin eutkin linked an issue Feb 18, 2020 that may be closed by this pull request
@eutkin eutkin requested a review from artem-v February 18, 2020 18:19
@eutkin eutkin requested a review from ronenhamias February 22, 2020 19:14
@eutkin eutkin closed this Feb 28, 2020
@eutkin eutkin deleted the feature/issue-708-di&security-extract-to-module branch February 28, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants