Make fresh name generation per file instead of global #7620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fresh-names-per-unit
branch
2 times, most recently
from
2f4c303 to
5a04232
Compare
nicolasstucki
approved these changes
Dec 2, 2019
This makes the compiler output more stable and avoids overcompilation during incremental compilation due to context bounds parameters changing name. This is still not fine-grained enough as noted in the documentation of CompilationUnit#freshNames. To work properly, this requires us to always have a compilation unit set in the context before compiling code, which is a good idea anyway (would be nice to improve the API to make this harder to screw up).
smarter
force-pushed
the
fresh-names-per-unit
branch
from
5a04232 to
e07a728
Compare
nicolasstucki
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the compiler output more stable and avoids overcompilation
during incremental compilation due to context bounds parameters changing
name. This is still not fine-grained enough as noted in the
documentation of CompilationUnit#freshNames.
To work properly, this requires us to always have a compilation unit set
in the context before compiling code, which is a good idea anyway (would
be nice to improve the API to make this harder to screw up).