Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circe-generic-extras #3517

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Remove circe-generic-extras #3517

merged 2 commits into from
Jan 5, 2025

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jan 4, 2025

This concludes the work started in #3514 and #3515 to remove the dependency on circe-generic-extras.

Here are some notes about the changes:

  • Resolver cases had non-optional fields with defaults that needed to be made optional so that the derived decoder does not fail if those are not provided
  • ArtifactChange and ArtifactChanges could have always used deriveDecoder since the case classes have no defaults
  • ScalafixMigrations had a default value but a scalafix-migrations.conf without a migrations field makes no sense to me and it should be the same as ArtifactChanges anyway

This concludes the work started in #3514 and #3515 to remove the
dependency on circe-generic-extras.

Here are some notes about the changes:
- `Resolver` cases had non-optional fields with defaults that needed to
  be made optional so that the derived decoder does not fail if those
  are not provided
- `ArtifactChange` and `ArtifactChanges` could have always used `deriveDecoder`
  since the case classes have no defaults
- `ScalafixMigrations` had a default value but a `scalafix-migrations.conf`
  without a `migrations` fields makes no sense to me and it should be the same
  as `ArtifactChanges` anyway
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (a31586b) to head (0f3ab16).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3517      +/-   ##
==========================================
+ Coverage   89.63%   89.73%   +0.10%     
==========================================
  Files         171      171              
  Lines        3540     3536       -4     
  Branches      331      321      -10     
==========================================
  Hits         3173     3173              
+ Misses        367      363       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fthomas fthomas added this to the 0.32.2 milestone Jan 4, 2025
@fthomas fthomas merged commit 0844668 into main Jan 5, 2025
12 checks passed
@fthomas fthomas deleted the topic/rm-circe-generic-extras branch January 5, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants