-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to hh tests - fixtures, split contract_address #29
Open
joescharf
wants to merge
1
commit into
scaffold-eth:challenge-1-decentralized-staking
Choose a base branch
from
joescharf:challenge-1-decentralized-staking
base: challenge-1-decentralized-staking
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improvements to hh tests - fixtures, split contract_address #29
joescharf
wants to merge
1
commit into
scaffold-eth:challenge-1-decentralized-staking
from
joescharf:challenge-1-decentralized-staking
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the PR. Sorry for the delay on reviewing this. I'm going to take a closer look tonight and try to get this merged. |
codenamejason
pushed a commit
to Sergik666/scaffold-eth-typescript-challenges
that referenced
this pull request
Aug 7, 2022
* scaffold-eth#29 testing out contracts context * scaffold-eth#29 v4 compatability changes and merging develop * scaffold-eth#29 eth-hooks v4 minor updates * scaffold-eth#29 more work on contract context scaffold-eth/eth-ui#101 - external contracts are now handles - worked on the contract context initalization in app * scaffold-eth#29 more work on contract context scaffold-eth/eth-ui#101 - created an contract context factory * scaffold-eth#29 preliminary typing system for all the app contracts * scaffold-eth#29 contract typing is almost working * scaffold-eth#29 checkpoint * scaffold-eth#29 checkpoint * scaffold-eth#29 regenerate lock file * scaffold-eth#29 general refactor of v4 types and function names * scaffold-eth#29 created hook and system to load contracts * scaffold-eth#29 using the new eth-hooksv4 paradigm * scaffold-eth#29 fixes from eth-hooksv4 and eth-components * scaffold-eth#29 fixes from eth-hooksv4 and eth-components * scaffold-eth#29 fixes from eth-hooksv4 loading contractrats * scaffold-eth#29 changes to how main provider is passed around * added react async * scaffold-eth#29 final changes to inital beta * scaffold-eth#29 final changes to inital beta * scaffold-eth#29 changes from scaffold-eth/eth-ui#114 * scaffold-eth#29 changes from scaffold-eth/eth-ui#114 * scaffold-eth#29 changes from scaffold-eth/eth-ui#114 event based updates * replace apollo with react-query and graphql-request. lazy load GraphiQl * scaffold-eth#29 tried to make folder structure simpler. better commands to build contracts * scaffold-eth#29 minor fixes * scaffold-eth#29 more comments to contract * update packages * scaffold-eth#46 fixes and autconnect to burner with an option * scaffold-eth#46 packages updates
codenamejason
pushed a commit
to Sergik666/scaffold-eth-typescript-challenges
that referenced
this pull request
Aug 7, 2022
* Feature/scaffold-eth#29 eth-hooks v4 changes (scaffold-eth#32) * scaffold-eth#29 testing out contracts context * scaffold-eth#29 v4 compatability changes and merging develop * scaffold-eth#29 eth-hooks v4 minor updates * scaffold-eth#29 more work on contract context scaffold-eth/eth-ui#101 - external contracts are now handles - worked on the contract context initalization in app * scaffold-eth#29 more work on contract context scaffold-eth/eth-ui#101 - created an contract context factory * scaffold-eth#29 preliminary typing system for all the app contracts * scaffold-eth#29 contract typing is almost working * scaffold-eth#29 checkpoint * scaffold-eth#29 checkpoint * scaffold-eth#29 regenerate lock file * scaffold-eth#29 general refactor of v4 types and function names * scaffold-eth#29 created hook and system to load contracts * scaffold-eth#29 using the new eth-hooksv4 paradigm * scaffold-eth#29 fixes from eth-hooksv4 and eth-components * scaffold-eth#29 fixes from eth-hooksv4 and eth-components * scaffold-eth#29 fixes from eth-hooksv4 loading contractrats * scaffold-eth#29 changes to how main provider is passed around * added react async * scaffold-eth#29 final changes to inital beta * scaffold-eth#29 final changes to inital beta * scaffold-eth#29 changes from scaffold-eth/eth-ui#114 * scaffold-eth#29 changes from scaffold-eth/eth-ui#114 * scaffold-eth#29 changes from scaffold-eth/eth-ui#114 event based updates * replace apollo with react-query and graphql-request. lazy load GraphiQl * scaffold-eth#29 tried to make folder structure simpler. better commands to build contracts * scaffold-eth#29 minor fixes * scaffold-eth#29 more comments to contract * update packages * scaffold-eth#46 fixes and autconnect to burner with an option * scaffold-eth#46 packages updates * changes for scaffold-eth/eth-ui#120 useBalance * scaffold-eth#47 changes to building contract, bug fixes, and updates to packages * reenabled dai * scaffold-eth#47 updated packages * scaffold-eth#47 updated packages, fixed externals for vite. * disabled subgraph for now scaffold-eth#48 * updated git ignore * scaffold-eth#47 fix to generic-contract. removed generated fiels * scaffold-eth#47 updated git ignore * scaffold-eth#47 updated action * scaffold-eth#47 updated action * scaffold-eth#47 updated action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was adding the hardhat tests for challenge 1, but looks like @pontus-dev beat me to it (nice!). However, my port of the challenge-1 tests improves on a few things beyond a direct port of the javascript version, so I'm submitting it in case it proves to be useful:
Should redeploy Staker, stake, not get enough, and withdraw
test where the Staking was being called with the default deployer address, but the withdraw was being requested withsecondAccount
which wouldn't have a positive balance in that scenario.This is my first PR for this repo, hopefully I'm not taking too many liberties with my refactor of the tests.