-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ts, eslint, prettier #963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rin-st!!
Just added a couple of comments
Also in tailwind.config.js
I see an error but on main
it doesn't seem to appear:
Also maybe its good chance to solve this warnings in .eslintrc
files ?
present at both nextjs and hardhat.
Also pushed a minor commit not related to this PR fixing the types of useScaffoldEventHistory
Thanks for the great comments!
It turns out that by default Plus:
|
Thanks Rinat!!
Umm I didn't get this changes 😅, also maybe its bad to pass it whole dir? and we should keep its as it was earlier what Also I see
Ohh so #901 appeared again? Should we ask Matt to test again? Just in case because its #901 never happened to me so can't test :/ |
We need to decide if we care about files like
Without that change After 9599964 error is found by Am I missing something?
Yes, but it's fixed now. @MattPereira hey, could you please test if #901 exists for you in this branch? (Checkout to branch -> yarn install -> (probably restart vscode) -> test code snippet from mentioned pr |
Umm I would vote for going with Also I am not sure about linitng JS files at gh actions / linstaged b0fb91b because people who are using JS believes in living on the edge? (move fast, break stuff is fine for them?), I think we are adding friction. Also I am not sure if people are actually using JS or not with SE-2 so lol I don't have strong opinion on this but slightly leaning towards not having lint checks and keep things as previous version |
Ok, I reverted these changes, but we should remember then that linting works only for default |
Tysm Rinat!! Just texted Port to do final testing on this #901 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @portdeveloper for test!!
Description
@typescript-eslint/eslint-plugin
from nextjspackage.json
since it's already included toeslint-config-next
"plugins": ["@trivago/prettier-plugin-sort-imports"]
to avoid warnings. From docscheck-types
script for hardhatNote:
eslint
v9 is still not supported by nextjs, so I used last v8 versionTo test take code snippet here
Additional Information
Related Issues