-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typescript eslint + up eslint #904
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bc49e28
fix: typescript eslint + up eslint
rin-st d655957
fix: ts-ignore -> ts-expect-error
rin-st 16d4c38
fix: remove comments
rin-st 91e96ba
fix: yarn lock
rin-st 49e1fa5
fix: update config
rin-st 85fae86
fix: lintstaged
rin-st ec43bb9
fix: type errors
rin-st 98f2706
fix: comment
rin-st File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
// @ts-check | ||
import { fixupPluginRules } from "@eslint/compat"; | ||
import { FlatCompat } from "@eslint/eslintrc"; | ||
import js from "@eslint/js"; | ||
import prettierConfigRecommended from "eslint-plugin-prettier/recommended"; | ||
import path from "node:path"; | ||
import { fileURLToPath } from "node:url"; | ||
import ts from "typescript-eslint"; | ||
|
||
const __filename = fileURLToPath(import.meta.url); | ||
const __dirname = path.dirname(__filename); | ||
const compat = new FlatCompat({ | ||
baseDirectory: __dirname, | ||
recommendedConfig: js.configs.recommended, | ||
allConfig: js.configs.all, | ||
}); | ||
|
||
const pluginsToPatch = ["@next/next", "react-hooks"]; | ||
|
||
const compatConfig = [...compat.extends("next/core-web-vitals")]; | ||
|
||
const patchedConfig = compatConfig.map(entry => { | ||
const plugins = entry.plugins; | ||
for (const key in plugins) { | ||
if (plugins.hasOwnProperty(key) && pluginsToPatch.includes(key)) { | ||
plugins[key] = fixupPluginRules(plugins[key]); | ||
} | ||
} | ||
return entry; | ||
}); | ||
|
||
const config = [ | ||
...patchedConfig, | ||
...ts.configs.recommended, | ||
{ | ||
languageOptions: { | ||
parserOptions: { | ||
projectService: { | ||
allowDefaultProject: ["*.js", "*.mjs"], | ||
}, | ||
tsconfigRootDir: import.meta.dirname, | ||
}, | ||
}, | ||
}, | ||
{ | ||
rules: { | ||
"no-unused-vars": "off", | ||
"@typescript-eslint/no-unused-vars": "error", | ||
"@typescript-eslint/no-explicit-any": "off", | ||
"@typescript-eslint/ban-ts-comment": "error", | ||
}, | ||
}, | ||
|
||
prettierConfigRecommended, // Last since it disables some previously set rules | ||
{ | ||
ignores: [ | ||
".next/*", | ||
"out/*", | ||
"node_modules/*", | ||
"**/*.less", | ||
"**/*.css", | ||
"**/*.scss", | ||
"**/*.json", | ||
"**/*.png", | ||
"**/*.svg", | ||
"**/generated/**/*", | ||
], | ||
}, | ||
]; | ||
|
||
export default config; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So basically instead of running next lint we are now doing our own lint, since next lint it broken right with v9?
Not sure if this is gonna affect us vercel/next.js#64409 (comment) or any user future of SE-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, see also vercel/next.js#64409 (comment). We can wait for next answers though