Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update merge packages info #79

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Jul 9, 2024

For me it wasn't clear how versions in merged package.json files are defined. From readme, I thought that always version from second package.json is taken. So I updated readme to make it clear for other devs.

Source https://github.com/zppack/merge-packages/blob/master/src/index.js#L104

If you want to test examples, you can add this to your first templates/base/packages/nextjs/package.json deps

    "a": "~1.2.3",
    "b": "^1.0.0",

and create new package.json at `templates/solidity-frameworks/hardhat/packages/nextjs/package.json

{
  "dependencies": {
    "a": "^1.0.0",
    "b": ">=1.2.0 <1.3.0"
  }
}

run

yarn cli -s hardhat --skip test-packages-merge

and check resulting nextjs package

@rin-st rin-st requested review from carletex and technophile-04 July 9, 2024 16:10
@carletex carletex merged commit af45c2e into main Jul 10, 2024
1 check passed
@carletex carletex deleted the update-merge-packages-info branch July 10, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants