forked from scaffold-eth/scaffold-eth-2
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weekly backmerge #69
Merged
Merged
Weekly backmerge #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
technophile-04
commented
Jun 26, 2024
- Better transaction result formatting in debug page (Better transaction result formatting in debug page scaffold-eth-2#853)
- fix: address components copy icon on small screens (fix: address components copy icon on small screens scaffold-eth-2#864)
- lock typescript and abitype version (lock typescript and abitype version scaffold-eth-2#871)
- rewrite useScaffoldEventHistory hook (rewrite useScaffoldEventHistory hook scaffold-eth-2#869)
Co-authored-by: Shiv Bhonde <[email protected]>
Co-authored-by: Shiv Bhonde <[email protected]>
technophile-04
commented
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried it out and everything seems fine
There is bug in foundry for contract verification(not related to this PR and also present in current npx create@latest)
Was fixed in #70
For me too! Thanks! |
rin-st
approved these changes
Jun 26, 2024
Thanks @rin-st! Merging this 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.