Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extensions styles #151

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Update extensions styles #151

merged 5 commits into from
Nov 26, 2024

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Nov 8, 2024

Origin scaffold-eth/create-eth-extensions#29 (comment)

Adds possibility

  • to import to global css
  • to set global classnames, for example in case of challenge 0 extension it is font-space-grotesk
  • to change thumbnail
  • to change metadata titleTemplate
  • updated tailwind config template to work with objects instead of strings

to test run from this branch

yarn dev

and then

yarn cli -e scaffold-eth/create-eth-extensions:update-ch0-styles

PR for challenge-0 extension changes scaffold-eth/create-eth-extensions#36

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this @rin-st !!

It worked great with update-ch0-styles branch, but just tried it with the old ch0 branch, using yarn cli -e scaffold-eth/create-eth-extensions:challenge-0-v2 , and it doesn't create my tailwind file correctly, ending in a page without styles:

image

Update:

  • Tried with a different extension (curated erc-20) and it worked fine.
  • With challenge-0-v2 extension, my generated tailwind file has some single quotes ' and escaped newlines \n, if I delete them the website looks fine:

image

@rin-st
Copy link
Member Author

rin-st commented Nov 21, 2024

Thanks for tackling this @rin-st !!

It worked great with update-ch0-styles branch, but just tried it with the old ch0 branch, using yarn cli -e scaffold-eth/create-eth-extensions:challenge-0-v2 , and it doesn't create my tailwind file correctly, ending in a page without styles:

It shouldn't work with old branch since I changed tailwind config generating. In a new branche update-ch0-styles it uses object instead of old stringifyed version, so that's why these branches are incompatible. The thing we should check is that create-eth works fine with new updates inside update-ch0-styles, and also create-eth still works with other extensions. As I understand the only things that could break are third-party extensions which use tailwind config. But we can let them now in the extensions chat after we merge this

Thanks!

@rin-st
Copy link
Member Author

rin-st commented Nov 22, 2024

Update: I merged scaffold-eth/create-eth-extensions#36 so now use challenge-0-v2 extension branch instead of update-ch0-styles

yarn cli -e scaffold-eth/create-eth-extensions:challenge-0-v2

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: I merged scaffold-eth/create-eth-extensions#36 so now use challenge-0-v2 extension branch instead of update-ch0-styles

Looks good to me!!

Don't think many of the current extensions have custom tailwind file, and probably the dev using those extension will figure out fast how to fix the generated tailwind file.

@carletex carletex merged commit d7d9321 into main Nov 26, 2024
1 check passed
@carletex carletex deleted the update-extensions-styles branch November 26, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants