-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extensions styles #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this @rin-st !!
It worked great with update-ch0-styles
branch, but just tried it with the old ch0 branch, using yarn cli -e scaffold-eth/create-eth-extensions:challenge-0-v2
, and it doesn't create my tailwind file correctly, ending in a page without styles:
Update:
- Tried with a different extension (curated erc-20) and it worked fine.
- With
challenge-0-v2
extension, my generated tailwind file has some single quotes'
and escaped newlines\n
, if I delete them the website looks fine:
It shouldn't work with old branch since I changed tailwind config generating. In a new branche Thanks! |
…-extensions-styles
Update: I merged scaffold-eth/create-eth-extensions#36 so now use
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: I merged scaffold-eth/create-eth-extensions#36 so now use challenge-0-v2 extension branch instead of update-ch0-styles
Looks good to me!!
Don't think many of the current extensions have custom tailwind file, and probably the dev using those extension will figure out fast how to fix the generated tailwind file.
Origin scaffold-eth/create-eth-extensions#29 (comment)
Adds possibility
font-space-grotesk
to test run from this branch
and then
PR for challenge-0 extension changes scaffold-eth/create-eth-extensions#36