Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process example solidity template only when required #148

Merged
merged 3 commits into from
Nov 4, 2024
Merged

process example solidity template only when required #148

merged 3 commits into from
Nov 4, 2024

Conversation

technophile-04
Copy link
Collaborator

@technophile-04 technophile-04 commented Nov 1, 2024 •
edited
Loading

Description :

Earlier it was processing the exampleSolidityContract path always causing the extensions to break like erc-20 when foundry was chosen.

npx create-eth@latest -e erc-20 -s foundry

^ This breaks.

To test:

Switch to this branch and then:

yarn dev
yarn cli -e erc-20 -s foundry

rin-st
rin-st approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! Thanks!

@technophile-04 technophile-04 merged commit 9b8a22e into main Nov 4, 2024
1 check passed
@technophile-04 technophile-04 deleted the fix-solidity-example-processing branch November 4, 2024 13:46
@technophile-04 technophile-04 mentioned this pull request Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rin-st rin-st rin-st approved these changes

@carletex carletex Awaiting requested review from carletex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@technophile-04 @rin-st