Allow to use a github url as extension #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't tested/reviewed it, but open to this! I think it doesn't add much complexity and it can come in handy. |
rin-st
reviewed
Dec 22, 2024
rin-st
approved these changes
Dec 22, 2024
technophile-04
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Thanks @damianmarti works nicely! Happy to merge it as it too, but lol agree with rinat's nit 🙌
|
Thanks @rin-st @technophile-04 for the review! Added the deconstructGithubUrl function! Please, do a final review before merging. |
technophile-04
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A low-priority draft PR.
A lot of times I tried to use a GitHub url as an extension param when running create-eth, so maybe something like this is useful.
The issue is that the GitHub URL can be wrong. Maybe there is something to avoid that.
This PR is just to open a discussion if this is worth...