Fix error in tensorboard plotting #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lappalainenj
approved these changes
Dec 1, 2023
| _type = type(data[0]) | ||
| for attribute in inspect.getfullargspec(_type).args: | ||
| if not attribute.startswith("_"): | ||
| if not attribute.startswith("_") and not attribute == "self": |
There was a problem hiding this comment.
Not sure when this happened but probably when tensorboard changed their event accumulator api from namedtuples to dataclass (which then causes the additional "self" attribute in the argspec). So this fix would do it! 👍
For reference, old event accumulator api https://github.com/tensorflow/tensorboard/blob/b84f3738032277894c6f3fd3e011f032a89d002c/tensorboard/backend/event_processing/event_accumulator.py#L37
and new api
https://github.com/tensorflow/tensorboard/blob/517a57e1c188f66006d201427e599b908465f5ba/tensorboard/backend/event_processing/event_accumulator.py#L43
There was a problem hiding this comment.
Ah, nice, thanks for the references!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lappalainenj FYI. I tried with older versions of torch and with older versions of sbi and it always broke so assume that this bug happened a while ago (not sure if it happened with a version bump of torch or with sbi). Let me know if you know a more elegant fix!
