Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1343 device handling in mog_log_prob #1356

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Jan 10, 2025

  • add test for multi-round training with mdn on GPU
  • fix device bug for constant
  • fix gpu-mcmc tests

fixes #1343

@janfb janfb requested a review from manuelgloeckler January 10, 2025 10:50
@janfb janfb force-pushed the fix-mdn-device-handling branch from 65fe33a to f385ee5 Compare January 10, 2025 11:11
Copy link
Contributor

@manuelgloeckler manuelgloeckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

New tests also pass on my GPU.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.42%. Comparing base (d3f22b5) to head (70c88b2).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
sbi/utils/sbiutils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1356       +/-   ##
===========================================
- Coverage   89.40%   78.42%   -10.99%     
===========================================
  Files         118      118               
  Lines        8715     8749       +34     
===========================================
- Hits         7792     6861      -931     
- Misses        923     1888      +965     
Flag Coverage Δ
unittests 78.42% <0.00%> (-10.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sbi/utils/sbiutils.py 78.11% <0.00%> (-8.68%) ⬇️

... and 34 files with indirect coverage changes

@janfb janfb merged commit 0ab3a14 into main Jan 10, 2025
5 of 6 checks passed
@janfb janfb deleted the fix-mdn-device-handling branch January 10, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

constant.device in mog_log_prob remains on cpu
2 participants