Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zuko kwargs #1130

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Fix zuko kwargs #1130

merged 2 commits into from
Apr 8, 2024

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Apr 8, 2024

The slow test tests/linearGaussian_snle_test.py::test_c2st_and_map_snl_on_linearGaussian_different is failing because we are passing nflows related kwargs to the zuko flow builder.

Excluding those kwargs fixes the problem.

@janfb janfb added the bug Something isn't working label Apr 8, 2024
@janfb janfb added this to the Hackathon 2024 milestone Apr 8, 2024
@janfb janfb self-assigned this Apr 8, 2024
@janfb janfb requested a review from michaeldeistler April 8, 2024 11:30
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.24%. Comparing base (7be2115) to head (9918213).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
- Coverage   85.45%   77.24%   -8.22%     
==========================================
  Files          90       89       -1     
  Lines        6612     6617       +5     
==========================================
- Hits         5650     5111     -539     
- Misses        962     1506     +544     
Flag Coverage Δ
unittests 77.24% <100.00%> (-8.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sbi/neural_nets/flow.py 93.04% <100.00%> (-5.58%) ⬇️

... and 23 files with indirect coverage changes

@janfb
Copy link
Contributor Author

janfb commented Apr 8, 2024

slow test are passing, except the PyMC stuff, see #1129

Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@janfb janfb merged commit 0720c78 into main Apr 8, 2024
6 of 7 checks passed
@janfb janfb deleted the fix-zuko-kwargs branch April 8, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants