Move cue-cut to requests. (#3617)

CHANGES.md

@@ -9,6 +9,7 @@ New:
 Changed:
 
 - Disable safety type checks when displaying `-h` help documentation to speed it up. Similar to passing `--unsafe`. Suggested by @gilou!
+- `cue_cut` operator has been removed. Cueing mechanisms have been moved to underlying file-based sources. See migration notes for more details.
 
 Fixed:
 

doc/content/migrating.md

@@ -43,6 +43,12 @@ Starting with version `2.2.1`, on HLS outputs, `on_file_change` events are now `
 was required to reflect the fact that file changes are now atomic. See [this issue](https://github.com/savonet/liquidsoap/issues/3284)
 for more details.
 
+### `cue_cut`
+
+Starting with version `2.2.4`, the `cue_cut` operator has been removed. Requests cue-in and cue-out processing has been integrated
+directly into requests resolution. In most cases, you simply can remove the operator from your script. In some cases, you might
+need to disable `cue_in_metadata` and `cue_out_metadat` either when creating new requests or when creating `playlist` sources.
+
 ### Harbor HTTP server and SSL support
 
 The API for registering HTTP server endpoint and using SSL was completely rewritten. It should be more flexible and

src/core/builtins/builtins_request.ml

@@ -27,6 +27,14 @@ let _ =
     ~descr:"Create a request from an URI."
     [
       ("indicators", Lang.list_t Lang.string_t, Some (Lang.list []), None);
+      ( "cue_in_metadata",
+        Lang.nullable_t Lang.string_t,
+        Some (Lang.string "liq_cue_in"),
+        Some "Metadata for cue in points. Disabled if `null`." );
+      ( "cue_out_metadata",
+        Lang.nullable_t Lang.string_t,
+        Some (Lang.string "liq_cue_out"),
+        Some "Metadata for cue out points. Disabled if `null`." );
       ( "persistent",
         Lang.bool_t,
         Some (Lang.bool false),
@@ -50,6 +58,12 @@ let _ =
       let indicators = List.assoc "indicators" p in
       let persistent = Lang.to_bool (List.assoc "persistent" p) in
       let resolve_metadata = Lang.to_bool (List.assoc "resolve_metadata" p) in
+      let cue_in_metadata =
+        Lang.to_valued_option Lang.to_string (List.assoc "cue_in_metadata" p)
+      in
+      let cue_out_metadata =
+        Lang.to_valued_option Lang.to_string (List.assoc "cue_out_metadata" p)
+      in
       let initial = Lang.to_string (List.assoc "" p) in
       let l = String.length initial in
       let initial =
@@ -66,7 +80,8 @@ let _ =
         else indicators
       in
       Request.Value.to_value
-        (Request.create ~resolve_metadata ~persistent ~indicators initial))
+        (Request.create ~resolve_metadata ~persistent ~indicators
+           ~cue_in_metadata ~cue_out_metadata initial))
 
 let _ =
   Lang.add_builtin ~base:request "resolve" ~category:`Liquidsoap

src/core/dune

@@ -84,7 +84,6 @@
   conversion
   configure
   cross
-  cuepoint
   debug_sources
   decoder
   decoder_utils