Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter checks in LegacyColor constructor #349

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Stricter checks in LegacyColor constructor #349

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dde8379
Check green and blue against `undefined` instead of just if they're f…
mrdziuban Nov 4, 2024
afdd1a9
Explicitly check for `undefined` or `null`.
mrdziuban Nov 4, 2024
5558d68
Use existing `isNullOrUndefined` function.
mrdziuban Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/src/legacy/value/color.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// MIT-style license that can be found in the LICENSE file or at
// https://opensource.org/licenses/MIT.

import {isNullOrUndefined} from '../../utils';
import {SassColor} from '../../value/color';
import {LegacyValueBase} from './base';

Expand All @@ -22,7 +23,7 @@ export class LegacyColor extends LegacyValueBase<SassColor> {
}

let red: number;
if (!green || !blue) {
if (isNullOrUndefined(green) || isNullOrUndefined(blue)) {
const argb = redOrArgb as number;
alpha = (argb >> 24) / 0xff;
red = (argb >> 16) % 0x100;
Expand Down